Alon Bar-Lev has posted comments on this change.

Change subject: pki: Add a script to extract parts from a PKCS#12
......................................................................


Patch Set 8: (2 inline comments)

whiting for the other plugins to be included, right?

....................................................
File packaging/bin/pki-pkcs12-extract.sh
Line 8: 
Line 9:         local pkcs12="${PKIDIR}/keys/${name}.p12"
Line 10:        common_backup "${key}"
Line 11: 
Line 12:        enc="-nodes"
see previous note of enc...
Line 13:        [ -n "${passout}" ] && enc=""
Line 14: 
Line 15:        if [ "${key}" = - ]; then
Line 16:                key=/dev/fd/1


Line 17:        else
Line 18:                touch "${key}"
Line 19:                chmod go-rwx "${key}" || die "Cannot set key 
permissions"
Line 20:        fi
Line 21:        # ${enc} is not quoted as openssl does not accept empty args
yes, this is obvious, because of this call it extra_args or something.
Line 22:        openssl \
Line 23:                pkcs12 \
Line 24:                -in "${pkcs12}" \
Line 25:                -passin "pass:${passin}" \


-- 
To view, visit http://gerrit.ovirt.org/17562
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ica596fe3ef4e5f0a60ae99b0934b10433b9d5023
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Yedidyah Bar David <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to