Mike Kolesnik has posted comments on this change.
Change subject: engine: Create a vnic profile implicitly when adding network
......................................................................
Patch Set 26: Looks good to me, approved
(1 inline comment)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddNetworkStoragePoolParameters.java
Line 26: public Network getNetwork() {
Line 27: return network;
Line 28: }
Line 29:
Line 30: public boolean isVnicProfileRequired() {
Hopefully you used this in a later patch, because I see no usage of this in
this patch
Line 31: return vnicProfileRequired;
Line 32: }
Line 33:
Line 34: public void setVnicProfileRequired(boolean vnicProfileRequired) {
--
To view, visit http://gerrit.ovirt.org/16991
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie8adb307aad864089cbccd5e05d8fc591b6cce60
Gerrit-PatchSet: 26
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
