Yedidyah Bar David has posted comments on this change.
Change subject: WIP: packaging: setup: Add host rename script
......................................................................
Patch Set 12: (2 inline comments)
....................................................
File packaging/setup/plugins/ovirt-engine-rename/core/database.py
Line 74: except RuntimeError:
Line 75: self.logger.debug(
Line 76: "Option {option} not found in db".format(
Line 77: option=option
Line 78: )
But if it just does not exist in the db, it's not an error. E.g. if reports is
not installed.
Perhaps I did not understand you or do not understand how exceptions work.
I also thought about changing the behavior of getVdcOption to not throw this
exception, or not throw one at all, as it seems that currently no-one is using
it, but I am not sure about that.
Line 79: )
Line 80: return
Line 81:
Line 82:
....................................................
File packaging/setup/plugins/ovirt-engine-rename/core/uninstall.py
Line 122:
Line 123: if (
Line 124: externally_modified_files and
Line 125: self.environment[
Line 126: osetupcons.RenameEnv.CONFIRM_FORCE_OVERWRITE]
Done :-)
Do you have any rule when to use each? Just <80col? pep8?
Line 127: ):
Line 128: self.logger.warn(
Line 129: _(
Line 130: 'The following files were externally modified -
outside '
--
To view, visit http://gerrit.ovirt.org/17408
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I28cb0285424236fd3e6907694f6bf1ce6ce3367f
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Moran Goldboim <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Yedidyah Bar David <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
