Yaniv Dary has posted comments on this change. Change subject: engine: Drop network_name and port_mirroring from vm_interface ......................................................................
Patch Set 22: (2 comments) .................................................... File packaging/dbscripts/create_dwh_views.sql Line 283: vm_interface.vm_guid AS vm_id, Line 284: cast(vm_interface.type as smallint) as vm_interface_type, Line 285: vm_interface.speed as vm_interface_speed_bps, Line 286: vm_interface.mac_addr AS mac_address, Line 287: network.name, Please add the table name to line: network.network.name or vnic_profiles.network.name Line 288: vm_interface._create_date AS create_date, Line 289: vm_interface._update_date AS update_date Line 290: FROM vm_interface Line 291: LEFT OUTER JOIN (vnic_profiles JOIN network ON network.id = vnic_profiles.network_id) Line 287: network.name, Line 288: vm_interface._create_date AS create_date, Line 289: vm_interface._update_date AS update_date Line 290: FROM vm_interface Line 291: LEFT OUTER JOIN (vnic_profiles JOIN network ON network.id = vnic_profiles.network_id) Please add the space required to align these rows. Line 292: ON vnic_profiles.id = vm_interface.vnic_profile_id Line 293: WHERE vmt_guid IS NULL AND Line 294: ((vm_interface._create_date > Line 295: (SELECT var_datetime -- To view, visit http://gerrit.ovirt.org/17130 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib03c3b3a923cc79f69509258cd45c7457df78c7e Gerrit-PatchSet: 22 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Mike Kolesnik <[email protected]> Gerrit-Reviewer: Yaniv Dary <[email protected]> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
