Lior Vernia has posted comments on this change.
Change subject: webadmin: adding network, dc and compatability version columns
to profiles
......................................................................
Patch Set 7: Code-Review+1
(2 comments)
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabVnicProfileView.java
Line 87: }
Line 88: };
Line 89: getTable().addColumnWithHtmlHeader(portMirroringColumn,
constants.portMirroringVnicProfile(), "85px"); //$NON-NLS-1$
Line 90:
Line 91: getTable().addColumn(descriptionColumn,
constants.descriptionVnicProfile(), "400px"); //$NON-NLS-1$
Are you sure you want the description column last? Usually we put it next to
the name.
Line 92:
Line 93: getTable().addActionButton(new
WebAdminButtonDefinition<VnicProfileView>(constants.newVnicProfile()) {
Line 94: @Override
Line 95: protected UICommand resolveCommand() {
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/network/SubTabNetworkProfileView.java
Line 78: public String getValue(VnicProfileView object) {
Line 79: return object.getDescription();
Line 80: }
Line 81: };
Line 82: getTable().addColumn(descriptionColumn,
constants.descriptionVnicProfile(), "400px"); //$NON-NLS-1$
Same question.
Line 83:
Line 84: getTable().addActionButton(new
WebAdminButtonDefinition<VnicProfileView>(constants.newNetworkProfile()) {
Line 85: @Override
Line 86: protected UICommand resolveCommand() {
--
To view, visit http://gerrit.ovirt.org/17573
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6507f1fd027c95db894158ba11a9b06fa0bad416
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Lior Vernia <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
