Mike Kolesnik has posted comments on this change.
Change subject: engine: Use VmNic within UpdateVmCommand
......................................................................
Patch Set 21:
(1 comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java
Line 180: for (final VmNic iface : interfaces) {
Line 181: Network net = LinqUtils.firstOrNull(networks, new
Predicate<Network>() {
Line 182: @Override
Line 183: public boolean eval(Network n) {
Line 184: Network network =
NetworkHelper.getNetworkByVnicProfileId(iface.getVnicProfileId());
Please note it would be more efficient to fetch this value before the "linq"
loop
Line 185: return ObjectUtils.equals(n.getId(),
network.getId());
Line 186: }
Line 187: });
Line 188:
--
To view, visit http://gerrit.ovirt.org/17272
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id8f84060667f97c613ea7ee2da65bb17478c52aa
Gerrit-PatchSet: 21
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
