Alissa Bonas has posted comments on this change.
Change subject: restapi: add connections subresource for domain
......................................................................
Patch Set 6:
(6 comments)
....................................................
Commit Message
Line 13: api/storagedomains/<domainId>/storageconnections
Line 14: and:
Line 15: api/storagedomains/<domainId>/storageconnections/<connectionId>
Line 16: Exposing GET only, no add/delete/update.
Line 17:
Done
Line 18: Change-Id: I0f63f8384c245eb28c18a3fde87ba57a8c1cd678
Line 13: api/storagedomains/<domainId>/storageconnections
Line 14: and:
Line 15: api/storagedomains/<domainId>/storageconnections/<connectionId>
Line 16: Exposing GET only, no add/delete/update.
Line 17:
Done
Line 18: Change-Id: I0f63f8384c245eb28c18a3fde87ba57a8c1cd678
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainServerConnectionResource.java
Line 22: new
StorageServerConnectionQueryParametersBase(guid.toString()));
Line 23: }
Line 24:
Line 25: @Override
Line 26: public Storage update(Storage connection) {
Done
Line 27: throw new UnsupportedOperationException();
Line 28: }
Line 29:
Line 30: @Override
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainServerConnectionsResource.java
Line 24: }
Line 25:
Line 26: @Override
Line 27: public StorageConnections list() {
Line 28: List<StorageServerConnections> connections = getConnections();
it's easier to troubleshoot/debug when it's separated instead of being inline.
Line 29: return mapCollection(connections);
Line 30: }
Line 31:
Line 32: protected List<StorageServerConnections> getConnections() {
Line 52: return collection;
Line 53: }
Line 54:
Line 55: @Override
Line 56: public Response add(Storage storage) {
Done
Line 57: throw new UnsupportedOperationException();
Line 58: }
Line 59:
Line 60: @Override
Line 57: throw new UnsupportedOperationException();
Line 58: }
Line 59:
Line 60: @Override
Line 61: public Response remove(String id, Host host) {
Done
Line 62: throw new UnsupportedOperationException();
Line 63: }
Line 64:
Line 65: @Override
--
To view, visit http://gerrit.ovirt.org/17245
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0f63f8384c245eb28c18a3fde87ba57a8c1cd678
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
