Roy Golan has posted comments on this change.
Change subject: core: Inject Config instance to CommandBase
......................................................................
Patch Set 3:
my comment is a bit misleading, I can loose the getInstance of Config and leave
just a default constructor right there.
its just not clear if you get an instance in hand if its init or not
getInstance methods will be dropped once all the engine
would have dependecy injected.
and then beans like that should have a constructor with deps injected:
@Inject
public Config(IConfigUtils utils) {...}
so its immutable and already init.
--
To view, visit http://gerrit.ovirt.org/17613
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I42517ed27b29bc91ffe5062ada651a1d5eb07bed
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
