Roy Golan has posted comments on this change.
Change subject: engine: Incorrect VM TimeZone handling
......................................................................
Patch Set 3: Code-Review-1
(1 comment)
I missing the handling of the index number of the windows timezone?
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/TimeZoneType.java
Line 12: import java.util.LinkedHashMap;
Line 13: import java.util.LinkedList;
Line 14: import java.util.List;
Line 15: import java.util.Map;
Line 16:
and then just a simple
Properties timezones = get it ...
timezones.get("timezones." + isWindows() ? "windows" : "general" +
.Asia/Baghdad")
Line 17: public enum TimeZoneType {
Line 18: GENERAL_TIMEZONE(ConfigValues.DefaultGeneralTimeZone,
ConfigurationValues.DefaultGeneralTimeZone) {
Line 19: @Override
Line 20: protected Map<String, String> initializeTimeZoneList() {
--
To view, visit http://gerrit.ovirt.org/17524
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd36656bd4f0288e86b1cbd46d702fa68051e28b
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Betak <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Martin Betak <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
