Maor Lipchuk has posted comments on this change.
Change subject: core: Fixes logging in SshSoftFencingCommand
......................................................................
Patch Set 6:
(1 comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SshSoftFencingCommand.java
Line 84: sshClient.executeCommand(Config.<String>
GetValue(ConfigValues.SshSoftFencingCommand, version),
Line 85: null,
Line 86: cmdOut,
Line 87: cmdErr);
Line 88: log.infoFormat("SSH Soft Fencing command executed on host
{0}", getVds().getHostName());
I would consider to move the info log to be before the execution of the command.
That way we could have more info if sshClient will be hang for some time.
Line 89: result = true;
Line 90: } catch (Exception ex) {
Line 91: log.errorFormat("SSH Soft Fencing command failed on host
{0}: {1}\nStdout: {2}\nStderr: {3}\nStacktrace: {4}",
Line 92: getVds().getHostName(), ex.getMessage(),
cmdOut.toString(), cmdErr.toString(), ex);
--
To view, visit http://gerrit.ovirt.org/16619
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6ea12003bd44f6500e3878176e98debd102da056
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Martin Peřina <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
