Sandro Bonazzola has uploaded a new change for review. Change subject: cleanup: explicit dict keys conversion to list ......................................................................
cleanup: explicit dict keys conversion to list In Python 3.3 dict keys() method returns a view, not a list. Adding explicit conversion when needed. Change-Id: Ie2cc9921cbaf67f2081039d0c5723bf07b53f87f Signed-off-by: Sandro Bonazzola <[email protected]> --- M src/plugins/ovirt-hosted-engine-setup/vm/configurevm.py M src/plugins/ovirt-hosted-engine-setup/vm/runvm.py 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-hosted-engine-setup refs/changes/71/17671/1 diff --git a/src/plugins/ovirt-hosted-engine-setup/vm/configurevm.py b/src/plugins/ovirt-hosted-engine-setup/vm/configurevm.py index 4a34652..ca09bde 100644 --- a/src/plugins/ovirt-hosted-engine-setup/vm/configurevm.py +++ b/src/plugins/ovirt-hosted-engine-setup/vm/configurevm.py @@ -102,7 +102,7 @@ ), prompt=True, caseSensitive=True, - validValues=self.BOOT_DEVICE.keys(), + validValues=list(self.BOOT_DEVICE.keys()), default=ohostedcons.Defaults.DEFAULT_BOOT, ) diff --git a/src/plugins/ovirt-hosted-engine-setup/vm/runvm.py b/src/plugins/ovirt-hosted-engine-setup/vm/runvm.py index 8c41a27..d1dbf17 100644 --- a/src/plugins/ovirt-hosted-engine-setup/vm/runvm.py +++ b/src/plugins/ovirt-hosted-engine-setup/vm/runvm.py @@ -218,7 +218,7 @@ ), prompt=True, caseSensitive=False, - validValues=answermap.keys(), + validValues=list(answermap.keys()), default='vnc', ) -- To view, visit http://gerrit.ovirt.org/17671 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ie2cc9921cbaf67f2081039d0c5723bf07b53f87f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
