Federico Simoncelli has uploaded a new change for review. Change subject: provider: add the onModification hook ......................................................................
provider: add the onModification hook Change-Id: I8ed9ef0f798727fbd543cd409d91653841a3a27d Signed-off-by: Federico Simoncelli <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/ForemanHostProviderProxy.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/OpenStackImageProviderProxy.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/ProviderProxy.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/UpdateProviderCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/network/openstack/OpenstackNetworkProviderProxy.java 5 files changed, 35 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/75/17675/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/ForemanHostProviderProxy.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/ForemanHostProviderProxy.java index fae0e1f..738b2cb 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/ForemanHostProviderProxy.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/ForemanHostProviderProxy.java @@ -106,6 +106,10 @@ } @Override + public void onModification() { + } + + @Override public void onRemoval() { } diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/OpenStackImageProviderProxy.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/OpenStackImageProviderProxy.java index 07be0c8..e79e995 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/OpenStackImageProviderProxy.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/OpenStackImageProviderProxy.java @@ -124,6 +124,21 @@ } @Override + public void onModification() { + List<StorageDomain> storageDomains = + getDbFacade().getStorageDomainDao().getAllByConnectionId(provider.getId()); + + // updating storage domain information + for (StorageDomain storageDomainEntry : storageDomains) { + StorageDomainStatic domainStaticEntry = + getDbFacade().getStorageDomainStaticDao().get(storageDomainEntry.getId()); + domainStaticEntry.setStorageName(provider.getName()); + domainStaticEntry.setDescription(provider.getDescription()); + getDbFacade().getStorageDomainStaticDao().update(domainStaticEntry); + } + } + + @Override public void onRemoval() { List<StorageDomain> storageDomains = getDbFacade() .getStorageDomainDao().getAllByConnectionId(provider.getId()); diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/ProviderProxy.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/ProviderProxy.java index 2435754..2d4bf6b 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/ProviderProxy.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/ProviderProxy.java @@ -26,6 +26,12 @@ void onAddition(); /** + * Callback executed when the provider is modified.<br> + * Useful to add provider-specific operations when the provider is modified. + */ + void onModification(); + + /** * Callback executed when the provider is removed.<br> * Useful to add provider-specific operations when the provider is removed. */ diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/UpdateProviderCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/UpdateProviderCommand.java index e5ca006..6352748 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/UpdateProviderCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/UpdateProviderCommand.java @@ -60,6 +60,12 @@ @Override protected void executeCommand() { getProviderDao().update(getProvider()); + + ProviderProxy providerProxy = ProviderProxyFactory.getInstance().create(getProvider()); + if (providerProxy != null) { + providerProxy.onModification(); + } + setSucceeded(true); } diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/network/openstack/OpenstackNetworkProviderProxy.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/network/openstack/OpenstackNetworkProviderProxy.java index 0944504..91c170d 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/network/openstack/OpenstackNetworkProviderProxy.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/network/openstack/OpenstackNetworkProviderProxy.java @@ -123,6 +123,10 @@ } @Override + public void onModification() { + } + + @Override public void onRemoval() { } -- To view, visit http://gerrit.ovirt.org/17675 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I8ed9ef0f798727fbd543cd409d91653841a3a27d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
