Greg Sheremeta has posted comments on this change.
Change subject: userportal,webadmin: frontend refactor phase 2
......................................................................
Patch Set 4: Code-Review+1
(1 comment)
....................................................
File
frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/communication/OperationProcessor.java
Line 133: * @param manager The {@code VdcOperationManager} that has the
operation.
Line 134: * @return A VdcOperationCallback.
Line 135: */
Line 136: @SuppressWarnings("unchecked")
Line 137: private VdcOperationCallback<?, ?> createCallback(final
VdcOperationManager manager) {
How do you feel about using terminology of "callback wrapper" or "callback
decorator" ? In the case of the list, it might even be a "callback composite".
I'm not sure which would be more correct. But I think a little more clarity
around "originals" and "wrappers" is the only thing missing.
For example.
might want to have a wrapper class (even if it's only a marker)
VdcOperationCallback --> VdcOperationCallbackWrapper
createCallback --> createCallbackWrapper
createListCallback --> createListCallbackWrapper
anywhere you say "new", I'd replace with "wrapper". "old and new" is not as
clear as "original and wrapper"
This latest patchset is much more clear, ty.
Line 138: return new VdcOperationCallback<VdcOperation<?, ?>, Object>()
{
Line 139: @Override
Line 140: public void onSuccess(final VdcOperation<?, ?> operation,
final Object result) {
Line 141: // Do nothing more than call original callback.
--
To view, visit http://gerrit.ovirt.org/17356
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id19491b8fd4f30ad3a88790eaad664d679b35e22
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <[email protected]>
Gerrit-Reviewer: Alexander Wels <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Greg Sheremeta <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
