Juan Hernandez has posted comments on this change. Change subject: core: Split UPN in case of open ldap "get user by upn" query ......................................................................
Patch Set 1: I think that this change is good and should be merged. But unfortunately it doesn't solve the issue described in the bug. The problem is that RESTAPI uses a query like "[email protected]: allnames=whatever" when searching the user that will be added. This query isn't translated into LDAP using the maps in LdapQueryMetadataFactoryImpl, but using ADSyntaxChecker, and there isn't any provision there to remove the @example.com part from the user name (the *LdapQueryFormatter class isn't used there). -- To view, visit http://gerrit.ovirt.org/17631 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1c566ac48136487f9ff4203ca0b9a4dd3bb8b37e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
