Moti Asayag has posted comments on this change.
Change subject: engine: Update the vnic profile resolution of ImportVmTempalte
......................................................................
Patch Set 15:
(2 comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmTemplateCommand.java
Line 401: nic.setLinked(iface.isLinked());
Line 402: nic.setSpeed(iface.getSpeed());
Line 403: nic.setType(iface.getType());
Line 404:
Line 405: if (!vmInterfaceManager.updateNicWithVnicProfile(iface,
10x. i think a proper way would be passing the iface and modifying it, and
later update the nic out of it.
It will reduce the amount of argument the updateNicWithVnicProfile expects.
Line 406: iface.getNetworkName(),
Line 407: iface.getVnicProfileName(),
Line 408: getVdsGroup().getcompatibility_version(),
Line 409: networksInVdsByName,
Line 410: vnicProfilesInDc,
Line 411: getCurrentUser().getUserId())) {
Line 412: invalidNetworkNames.add(iface.getNetworkName());
Line 413: invalidIfaceNames.add(iface.getName());
Line 414: iface.setVnicProfileId(null);
see next patch for the suggested solution.
Line 415: }
Line 416:
Line 417: getVmNicDao().save(nic);
Line 418: getCompensationContext().snapshotNewEntity(nic);
--
To view, visit http://gerrit.ovirt.org/17444
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I59004e5c61d2fc98c6d6e26fdb16dc0c469acaf4
Gerrit-PatchSet: 15
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Giuseppe Vallarelli <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
