Alon Bar-Lev has posted comments on this change.
Change subject: engine_page: rewrite register
......................................................................
Patch Set 2:
(3 comments)
....................................................
File src/misc.py
Line 40: prefix = ''
Line 41: if not self.__module__.startswith(self._LOG_PREFIX):
Line 42: prefix = self._LOG_PREFIX
Line 43:
Line 44: self.logger = logging.getLogger(prefix + self.__module__)
we will move this code to base in future.
Line 45:
Line 46: def executeRaw(
Line 47: self,
Line 48: args,
Line 183: raiseOnError=False
Line 184: )
Line 185: if rc != 0 or len(stdout) != 1:
Line 186: self.logger.warning('Invalid dmidecode output')
Line 187: elif stdout[0].startswith('Not '):
if you leave vdsmId None you can handle all later.
Line 188: self.logger.warning('No system uuid')
Line 189: vdsmId = str(uuid.uuid4())
Line 190: with open(self._P_VDSM_NODE_ID, 'w') as f:
Line 191: f.write(vdsmId)
Line 198: with open('/proc/device-tree/system-id') as f:
Line 199: vdsmId = f.readline().rstrip('\0').replace(',',
'')
Line 200:
Line 201: if vdsmId is None:
Line 202: vdsmId = str(uuid.uuid4())
if you put it here, then move the persist into here.
Line 203:
--
To view, visit http://gerrit.ovirt.org/17682
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I38f3b800c445f8dbb0fa0e89d128cea1e3407798
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-node-plugin-vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
