Oved Ourfali has uploaded a new change for review. Change subject: webadmin: enforce authentication when using foreman provider ......................................................................
webadmin: enforce authentication when using foreman provider Change-Id: Ibdef39198da0842dc55afebe96e09097bf2f9390 Signed-off-by: Oved Ourfali <[email protected]> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/AddProviderModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/ProviderModel.java 2 files changed, 9 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/97/17697/1 diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/AddProviderModel.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/AddProviderModel.java index d596784..813c379 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/AddProviderModel.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/AddProviderModel.java @@ -14,7 +14,6 @@ setHashName("add_provider"); //$NON-NLS-1$ getType().setSelectedItem(Linq.firstOrDefault((Iterable<ProviderType>) getType().getItems())); - getRequiresAuthentication().setEntity(false); getNeutronAgentModel().init(provider); // this is okay because AdditionalProperties == null at this point } diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/ProviderModel.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/ProviderModel.java index f2d6fee..3852d97 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/ProviderModel.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/ProviderModel.java @@ -138,6 +138,11 @@ return type == ProviderType.OPENSTACK_NETWORK || type == ProviderType.OPENSTACK_IMAGE; } + private boolean isTypeRequiresAuthentication() { + ProviderType type = (ProviderType) getType().getSelectedItem(); + return type == ProviderType.FOREMAN; + } + private String getDefaultUrl(ProviderType type) { if (type == null) { return new String(); @@ -194,6 +199,10 @@ boolean isNeutron = isTypeOpenStackNetwork(); getApiVersion().setIsAvailable(isNeutron); getNeutronAgentModel().setIsAvailable(isNeutron); + + boolean requiresAuth = isTypeRequiresAuthentication(); + getRequiresAuthentication().setEntity(Boolean.valueOf(requiresAuth)); + getRequiresAuthentication().setIsChangable(!requiresAuth); } }); -- To view, visit http://gerrit.ovirt.org/17697 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ibdef39198da0842dc55afebe96e09097bf2f9390 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
