Gilad Chaplik has posted comments on this change. Change subject: frontend: fix broken tests ......................................................................
Patch Set 1: Code-Review+2 (1 comment) .................................................... File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java Line 68: Integer maxVmNameLengthWindows = (Integer) AsyncDataProvider.getConfigValuePreConverted(ConfigurationValues.MaxVmNameLengthWindows); Line 69: WINDOWS_VM_NAME_MAX_LIMIT = maxVmNameLengthWindows == null ? 15 : maxVmNameLengthWindows; Line 70: Line 71: Integer maxVmNameLengthNonWindows = (Integer) AsyncDataProvider.getConfigValuePreConverted(ConfigurationValues.MaxVmNameLengthNonWindows); Line 72: NON_WINDOWS_VM_NAME_MAX_LIMIT = maxVmNameLengthNonWindows == null ? 64 : maxVmNameLengthNonWindows; not the optimal solution... I'd extract a method 'getWINDOWS_VM_NAME_MAX_LIMIT()' and mock it in the test. you can fix it later on. Line 73: } Line 74: Line 75: private boolean privateIsNew; Line 76: -- To view, visit http://gerrit.ovirt.org/17706 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia570c7e06f0c411025ae0a694225ccac83250d3f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
