Sahina Bose has posted comments on this change.
Change subject: webadmin : changed create volume to new and sub tab title to
new volume
......................................................................
Patch Set 4: Code-Review+1
(1 comment)
Minor comment inline
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java
Line 90:
Line 91: @DefaultStringValue("Providers")
Line 92: String providerMainTabLabel();
Line 93:
Line 94: @DefaultStringValue("General")
Does this belong here? I thought u have separate patch for this?
Line 95: String volumeGeneralSubTabLabel();
Line 96:
Line 97: @DefaultStringValue("Volume Options")
Line 98: String volumeParameterSubTabLabel();
--
To view, visit http://gerrit.ovirt.org/17663
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib32adbb4c0c59c5e30bc1d22c3c42d40c47cca0b
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: anmolbabu <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: anmolbabu <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
