Roy Golan has posted comments on this change.
Change subject: core: Block changing sound device configuration for running vm
......................................................................
Patch Set 1:
(1 comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java
Line 331: if (getParameters().isSoundDeviceEnabled() != null &&
!getVm().isDown()
Line 332: && vmDeviceChanged(VmDeviceGeneralType.SOUND,
getParameters().isSoundDeviceEnabled())) {
Line 333: return
failCanDoAction(VdcBllMessages.ACTION_TYPE_FAILED_VM_IS_RUNNING);
Line 334: }
Line 335:
those are 2 different violations ( can't change console and sound devices) and
we faile them with completley vague message.
we have to make a message that is generic for device changes on vm status.
similar to blocking editing of VM fields
Line 336: return true;
Line 337: }
Line 338:
Line 339: private boolean vmDeviceChanged(VmDeviceGeneralType deviceType,
boolean deviceEnabled) {
--
To view, visit http://gerrit.ovirt.org/17011
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I923299830e1497306b7c5a2b25e9c3e523f20d29
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Frank Kobzik <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
