Sandro Bonazzola has posted comments on this change.
Change subject: packaging: setup: sanlock lockspace init
......................................................................
Patch Set 1:
(1 comment)
....................................................
File src/plugins/ovirt-hosted-engine-setup/sanlock/lockspace.py
Line 122: lease_file=lease_file,
Line 123: )
Line 124: )
Line 125: if not os.path.isdir(metadatadir):
Line 126: self.logger.debug('Creating metadata directory')
The following mkdir and open works only if NFS is exported without root
squashing.
Need to check if with root squashing just using setegid and seteuid to kvm vdsm
and setting umask is enough (something like what we do with iso-uploader)
Line 127: os.mkdir(metadatadir)
Line 128: os.chown(
Line 129: metadatadir,
Line 130: self.environment[ohostedcons.VDSMEnv.VDSM_UID],
--
To view, visit http://gerrit.ovirt.org/17713
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife56590bf3e6c17368a24ef8e9af6d42adc5ea42
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Greg Padgett <[email protected]>
Gerrit-Reviewer: Lev Veyde <[email protected]>
Gerrit-Reviewer: Moran Goldboim <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Yedidyah Bar David <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
