Yedidyah Bar David has posted comments on this change.
Change subject: packaging: setup: support OVF import
......................................................................
Patch Set 5:
(1 comment)
....................................................
File src/plugins/ovirt-hosted-engine-setup/vm/boot_disk.py
Line 252: )
Line 253: for filename in tar.getnames():
Line 254: self.logger.debug(filename)
Line 255: if (
Line 256: filename.startswith('master') and
See this one for example:
http://openvpn.net/index.php/access-server/download-openvpn-as-vm/469-deploying-openvpn-access-server-from-an-ovf-template-in-vmware-esxi-environment.html
I did not try hosted-engine on this image (and nor image uploader), but it
seems to me like it will fail in several different places including "master":
I do not see there Content/Name, but do see VirtualSystem/Name
No Section/Disk, yes DiskSection/Disk
No size, Yes capacity
No disk-alias
num of cpus/sockets is different
It has several different AllocationUnits, none is MegaBytes
Note that in addition to know knowing anything about ovf I know almost nothing
about xml, and nothing about xsd :-)
What image did you test it with?
Line 257: os.path.splitext(filename)[1] == '.ovf'
Line 258: ):
Line 259: ovf_xml = filename
Line 260: break
--
To view, visit http://gerrit.ovirt.org/17521
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I04b1de72c19e558b20d46e9fe6a435c594b0005d
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Greg Padgett <[email protected]>
Gerrit-Reviewer: Lev Veyde <[email protected]>
Gerrit-Reviewer: Moran Goldboim <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Yedidyah Bar David <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
