Daniel Erez has posted comments on this change.
Change subject: webadmin: add profiles tab to add/edit network dialogs
......................................................................
Patch Set 19: Code-Review+2
(2 comments)
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/AbstractNetworkPopupView.java
Line 198: isVmNetworkEditor.setLabel(constants.vmNetworkLabel());
Line 199: vlanTagging.setLabel(constants.enableVlanTagLabel());
Line 200: hasMtuEditor.setLabel(constants.overrideMtuLabel());
Line 201: publicUseEditor.setLabel(constants.networkPublicUseLabel());
Line 202:
redundant
Line 203: profilesLabel.setText(constants.profilesLabel());
Line 204: }
Line 205:
Line 206: protected void addStyles() {
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/AbstractNetworkPopupView.ui.xml
Line 115: </t:tab>
Line 116: <t:tab>
Line 117: <t:DialogTab ui:field="profilesTab">
Line 118: <t:content>
Line 119: <g:FlowPanel>
tws
Line 120: <g:Label
ui:field="profilesLabel" addStyleNames="{style.mainLabel}" />
Line 121: <v:VnicProfilesEditor
ui:field="profilesEditor" />
Line 122: </g:FlowPanel>
Line 123: </t:content>
--
To view, visit http://gerrit.ovirt.org/17499
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1b88f0458862e136e5ff035883cb044ef1e896b5
Gerrit-PatchSet: 19
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Lior Vernia <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
