Maor Lipchuk has posted comments on this change.
Change subject: Fix log print values when vdsm version is not supported in
cluster
......................................................................
Patch Set 2:
(2 comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HandleVdsVersionCommand.java
Line 1: package org.ovirt.engine.core.bll;
Line 2:
Line 3: import static
org.ovirt.engine.core.common.businessentities.NonOperationalReason.VERSION_INCOMPATIBLE_WITH_CLUSTER;
Line 4: import static
org.ovirt.engine.core.common.businessentities.NonOperationalReason.CLUSTER_VERSION_INCOMPATIBLE_WITH_CLUSTER;
again, why use import static?
Line 5:
Line 6: import java.util.HashMap;
Line 7: import java.util.HashSet;
Line 8: import java.util.Map;
....................................................
File
backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
Line 348: USER_FAILED_CLEAR_UNKNOWN_VMS=Failed to clear VMs' status on Non
Responsive Host ${VdsName}. (User: ${UserName}).
Line 349: CERTIFICATE_FILE_NOT_FOUND=Could not find oVirt Engine Certificate
file.
Line 350: VDS_RUN_IN_NO_KVM_MODE=Host ${VdsName} running without virtualization
hardware acceleration
Line 351: VDS_VERSION_NOT_SUPPORTED_FOR_CLUSTER=Host ${VdsName} is installed
with VDS version (${VdsSupportedVersions}) and cannot join cluster
${VdsGroupName} which is compatible with VDS versions ${CompatibilityVersion}.
Line 352: VDS_CLUSTER_VERSION_NOT_SUPPORTED=Host ${VdsName} is compatible with
versions (${VdsSupportedClusters}) and cannot join Cluster ${VdsGroupName}
which is set to version ${CompatibilityVersion}.
it should be here VdsSupportedVersions?
Line 353: RUN_VM_FAILED=Cannot run VM ${VmName} on Host ${VdsName}. Error:
${ErrMsg}
Line 354: USER_ADD_PERMISSION=User/Group ${SubjectName} was granted permission
for Role ${RoleName} on ${VdcObjectType} ${VdcObjectName}, by ${UserName}.
Line 355: USER_ADD_PERMISSION_FAILED=User ${UserName} failed to grant
permission for Role ${RoleName} on ${VdcObjectType} ${VdcObjectName} to
User/Group ${SubjectName}.
Line 356: USER_REMOVE_PERMISSION=User/Group ${SubjectName} Role ${RoleName}
permission was removed from ${VdcObjectType} ${VdcObjectName} by ${UserName}
--
To view, visit http://gerrit.ovirt.org/17719
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iacfb3875a0617f978b4453769a0b1c5704282fa5
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Martin Sivák <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
