Alissa Bonas has posted comments on this change.
Change subject: packaging: services: ovirt-engine: dump memory on
OutOfMemoryError is now default
......................................................................
Patch Set 9:
(1 comment)
....................................................
File packaging/sys-etc/logrotate.d/ovirt-engine.in
Line 15: rotate 1
Line 16: }
Line 17:
Line 18: "@ENGINE_LOG@/dump"/*.hprof {
Line 19: monthly
1.@Ofer -out of memory should not happen weekly. if it happens weekly,
compression is the least of the engine's problems, but I guess that weekly
compression doesn't do harm... :)
2.@Alon -since the dump files are going to stay there -are the existing ones
going to be recompressed every week/month or only the newly added ones?
3.@Ofer -dumps can be pretty big -(hundreds of MB, 1.5 GB), etc - depends on
how much mem is configured for java process, and at which point it crashed. (it
could crash on perm size and not reach its maximum heap size)
4.@Liran -which log in engine will indicate the occurence of out of memory
exception and the name of the dump created? worth to document where to search
for it for troubleshooting, especially since the exception also indicates the
symptom - whether oom was in heap,perm, etc...
Line 20: missingok
Line 21: compress
Line 22: nocreate
Line 23: rotate 1
--
To view, visit http://gerrit.ovirt.org/17466
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia2690bd371847561717a38410b4431f5e0edb185
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liran Zelkha <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Liran Zelkha <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
