Omer Frenkel has posted comments on this change.
Change subject: core: introduce command that removes hibernation volumes
......................................................................
Patch Set 1:
(3 comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmHibernationVolumesCommand.java
Line 15: import org.ovirt.engine.core.utils.GuidUtils;
Line 16: import org.ovirt.engine.core.utils.linq.LinqUtils;
Line 17: import org.ovirt.engine.core.utils.linq.Predicate;
Line 18:
Line 19: @NonTransactiveCommandAttribute
missing getAuditLogValue() impl, or mark the command as internal (i think) in
order to avoid it
Line 20: public class RemoveVmHibernationVolumesCommand<T extends
RemoveVmHibernationVolumesParameters> extends CommandBase<T> {
Line 21:
Line 22: public static final String DELETE_PRIMARY_IMAGE_TASK_KEY =
"DELETE_PRIMARY_IMAGE_TASK_KEY";
Line 23: public static final String DELETE_SECONDARY_IMAGES_TASK_KEY =
"DELETE_SECONDARY_IMAGES_TASK_KEY";
Line 41: return AsyncTaskType.deleteImage;
Line 42: }
Line 43:
Line 44: protected boolean removeMemoryVolumes(String memVols) {
Line 45: // this is temp code until it will be implemented in SPM
not really, right? i lost the faith in this sentence few years ago already
Line 46: List<Guid> guids = GuidUtils.getGuidListFromString(memVols);
Line 47:
Line 48: if (guids.size() == 6) {
Line 49: // get all vm disks in order to check post zero - if one
of the
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommandBase.java
Line 190:
Line 191: VdcReturnValueBase vdcRetValue =
getBackend().runInternalAction(
Line 192: VdcActionType.RemoveVmHibernationVolumes,
Line 193: removeVmHibernationVolumesParameters,
Line 194:
ExecutionHandler.createDefaultContexForTasks(getExecutionContext()));
dont you care if it succeeded?
Line 195:
Line 196: for (Guid taskId : vdcRetValue.getInternalVdsmTaskIdList()) {
Line 197: AsyncTaskManager.getInstance().StartPollingTask(taskId);
Line 198: }
--
To view, visit http://gerrit.ovirt.org/17692
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I425060c820e03f5818600fa119a70199d1a67840
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
