Michael Pasternak has posted comments on this change.
Change subject: restapi: add ReadOnlyResource
......................................................................
Patch Set 3: Code-Review-1
looking deeper to the change i see that you changed from
public interface ReadOnlyDeviceResource<D extends BaseDevice> extends
AsynchronouslyCreatedResource
to
public interface ReadOnlyDeviceResource<D extends BaseDevice> extends
ReadOnlyResource {
public interface ReadOnlyResource<D extends BaseResource> extends
AsynchronouslyCreatedResource {
the thing is that Resource not necessary "is a" AsynchronouslyCreatedResource,
while DeviceResource comply with AsynchronouslyCreatedResource, actually it was
one
of the main differences/triggers for this separation,
so i'm doubt if it worth the effort, maybe we should just create new
ReadOnlyResource
and leave ReadOnlyDeviceResource as is.
--
To view, visit http://gerrit.ovirt.org/17347
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic77b92b0e696e8ad0a0095006772320ac2f0600a
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
