Greg Padgett has posted comments on this change.
Change subject: core: allow using cloud init only from 3.3
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
Looks like a good change to me. The config value id needs updating, but that's
expected...
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
Line 1483:
Line 1484:
Line 1485: @TypeConverterAttribute(Boolean.class)
Line 1486: @DefaultValueAttribute("true")
Line 1487: CloudInitSupported(523),
523 was taken between your 2nd and 3rd patch sets, I guess it'll need to be
updated right before merging...
Line 1488:
Line 1489: Invalid(65535);
Line 1490:
Line 1491: private int intValue;
--
To view, visit http://gerrit.ovirt.org/17476
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I88d4ba3ca4dc24bdd3c12aeaf8168683e60096d9
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Greg Padgett <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
