Omer Frenkel has posted comments on this change.
Change subject: core: log set VM ticket event
......................................................................
Patch Set 1:
(2 comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SetVmTicketCommand.java
Line 191: }
Line 192:
Line 193: @Override
Line 194: public AuditLogType getAuditLogTypeValue() {
Line 195: return AuditLogType.VM_SET_TICKET;
really? even if it failed?
Line 196: }
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java
Line 91: VAR__ACTION__END,
Line 92: VAR__ACTION__CLEAR,
Line 93: VAR__ACTION__FORCE_SELECT,
Line 94: VAR__ACTION__EXTEND_IMAGE_SIZE,
Line 95: VAR__ACTION__SET_TICKET,
if you add new message you need to add translation to it, and remove the old
one if its not in use.
personally i dont see a reason to change this
Line 96:
Line 97: // Host statuses replacements
Line 98: VAR__HOST_STATUS__UP,
Line 99: VAR__HOST_STATUS__UP_MAINTENANCE_OR_NON_OPERATIONAL,
--
To view, visit http://gerrit.ovirt.org/17742
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I61308fdd59d0d11b045a8e1ed72648c85f039701
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
