Liron Ar has posted comments on this change.
Change subject: core, restapi: add GetVmOvfConfigurationQuery
......................................................................
Patch Set 10:
(1 comment)
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendSnapshotsResource.java
Line 127: }
Line 128:
Line 129: @Override
Line 130: protected Snapshot doPopulate(Snapshot model,
org.ovirt.engine.core.common.businessentities.Snapshot entity) {
Line 131: if (isPopulate()) {
Michael, in AbstractBackendCollectionResource implementation of mapEntity() the
doPopulate() method method is always called, so i had to add this if.
i guess that it could be changed to execute populate() instead and then this if
won't be needed - as it's a class which many class inherit from, i preferred to
not handle this in this patch. let me know what's your take on that.
Line 132: VdcQueryReturnValue queryReturnValue =
Line 133:
runQuery(VdcQueryType.GetVmOvfConfigurationBySnapshot,
Line 134: new
IdQueryParameters(Guid.createGuidFromString(model.getId())));
Line 135:
--
To view, visit http://gerrit.ovirt.org/16176
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I46340c4461b57a4c314fb50ca9c19ac5fd08a451
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Deepak C Shetty <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
