Yedidyah Bar David has posted comments on this change. Change subject: packaging: setup: Do not read ovirt-engine.rpmsave ......................................................................
Patch Set 1: Background: In ovirt-engine 3.2 the main configuration file was /etc/sysconfig/ovirt-engine . In 3.3 it's not used anymore. However, during upgrade we need to read it in order to use the existing configuration. When the rpm is upgraded, which should normally happen only during the run of engine-upgrade, this file is renamed to ovirt-engine.rpmsave by rpm. Prior to this patch, the upgrade code read both files, "just in case". A recent patch also renamed the file back from ovirt-engine.rpmsave to ovirt-engine, which prevented some bugs that happened by reading ovirt-engine.rpmsave under certain occasions. Still, it's better not to read it at all. A non-realistic example of when it still might cause problems: 1. update from 3.2 to 3.3 2. engine-cleanup, during which we choose to keep the keys and db 3. engine-setup During the last stage, /etc/sysconfig/ovirt-engine will be read (and prior to a recent change, /etc/sysconfig/ovirt-engine.rpmsave was read), while we already have more recent configuration from the 3.3 setup. I spent a long time today trying to reproduce an old bug which was actually solved by Alon's 9a96a9e02d5f47c43d6f9e0ac7eac6367d7ecda4, also in relation to https://bugzilla.redhat.com/987939 . Although I have no clear opnion and suggestion, I think that the setup/upgrade definition is not clear enough and should be strengthened. If you prefer to start a discussion on some mailing list regarding this, it might be better, dunno. -- To view, visit http://gerrit.ovirt.org/17846 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibf8a297afdc8bde2442c3874c2bbfed82651aa78 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: Alex Lourie <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Ofer Schreiber <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
