Yair Zaslavsky has posted comments on this change.
Change subject: [WIP] Replace GetAdUserByUserId with generic interface
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Giving +1 as I would like to get Juan's comment on this.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddUserCommand.java
Line 35: if (getParameters().getVdcUser() != null) {
Line 36: addCustomValue("NewUserName",
getParameters().getVdcUser().getUserName());
Line 37: userId = getParameters().getVdcUser().getUserId();
Line 38: domain = getParameters().getVdcUser().getDomainControler();
Line 39: Directory directory =
DirectoryManager.getInstance().getDirectory(domain);
Hi Juan,
Not entirely critical, but maybe it would be nice we can have
getDirectoryManager() wrapping this? Would be nice for future addition of
testing of AddUserCommand.
This is a general comment for this.
Line 40: if (directory == null) {
Line 41:
addCanDoActionMessage(VdcBllMessages.USER_MUST_EXIST_IN_DIRECTORY);
Line 42: return false;
Line 43: }
--
To view, visit http://gerrit.ovirt.org/15757
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9a4311c3eed0c120408f3390ed23cab695ba2da9
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
