Liron Ar has posted comments on this change.
Change subject: engine : Null Pointer Exception for action
CreateAllSnapshotsFromVm after failure in create snapshot
......................................................................
Patch Set 5:
(1 comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java
Line 132: addSnapshotToDB(createdSnapshotId, memoryImageBuilder);
Line 133: createSnapshotsForDisks();
Line 134: memoryImageBuilder.build();
Line 135:
Line 136: getParameters().setTaskGroupSuccess(false);
Ravi, perhaps i missed something - how this solves the issue? can you please
elaborate?
the tasks are created before, so i don't see how does this will affect the flow.
regardless, i think that the needed change should be done generally to all
commands to avoid having this issue repeated and not specifically for this flow.
Line 137: if (getTaskIdList().isEmpty()) {
Line 138: incrementVmGeneration();
Line 139: }
Line 140:
--
To view, visit http://gerrit.ovirt.org/17590
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If89c45a236029078eae4a4254837b373c88adfd2
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
