Yedidyah Bar David has posted comments on this change.
Change subject: packaging: setup: Clear rollback message
......................................................................
Patch Set 1:
Alon Bar-Lev wrote:
> I do not agree that order should make any difference, as plugins may be added
> and modified and break the application on such assumptions.
I do not understand what will break when.
You want to have the option to implement _main.append using something different
from a list, which does not keep its order?
> And I really don't understand why it is important when we display the message
> as long as it is before the long process.
Currently, as I explained in the beginning, it's not before "the long process",
it's after it. In the middle, actually - old RPMs are downloaded and installed,
then we display the message, then do other stuff.
> Sorry, but I do not understand the reason to add extra complexity for a
> message.
What extra complexity? I added a single trivial plugin, and did not touch
anything else.
> You can put 'rolling back ...' message in each transaction if you are so
> bothered, then you have rolling database, rolling packaging....
Is that what you want?
This can also be done in just a single place, instead of each of them - in
otopi's Transaction.abort. It already has self.logger.debug("aborting '%s'",
element), I can add logger.warning. Will you accept it?
--
To view, visit http://gerrit.ovirt.org/17845
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieec07031079e23b23f59e166d647988743dffb7b
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Moran Goldboim <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Yedidyah Bar David <[email protected]>
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
