Michael Pasternak has posted comments on this change.
Change subject: restapi: RSDL - add 'deprecated' option
......................................................................
Patch Set 3: Code-Review-1
(3 comments)
ori, to verify this patch please:
1. compile + fetch rsdl before the change
2. compile + fetch rsdl afeter the change
3. compare #1 and #2
....................................................
Commit Message
Line 7: restapi: RSDL - add 'deprecated' option
Line 8:
Line 9: Mark parameter as deprecated in rsdl_metadata.yaml file this way:
Line 10:
Line 11: (example): vm.display.type--DEPRECATED: xs:string
what about url/header params?
Line 12:
Line 13: Change-Id: I5537c9065c13d9a68c88ab40ebf523bfe71e2a7b
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/rsdl/RsdlBuilder.java
Line 424
Line 425
Line 426
Line 427
Line 428
what about setting the paramName?
Line 427: return param;
Line 428: }
Line 429:
Line 430: private void handleCollection(Entry<Object, Object>
mandatoryKeyValuePair, boolean required, Parameter param) {
Line 431: param.setType(COLLECTION_PARAMETER_RSDL);
what about setting the paramName?
Line 432: @SuppressWarnings("unchecked")
Line 433: Map<Object, Object> listParams = (Map<Object,
Object>)mandatoryKeyValuePair.getValue();
Line 434: param.setParametersSet(new ParametersSet());
Line 435: for (Entry<Object, Object> listParamData :
listParams.entrySet()) {
--
To view, visit http://gerrit.ovirt.org/17624
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5537c9065c13d9a68c88ab40ebf523bfe71e2a7b
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ori Liel <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
