Michael Pasternak has posted comments on this change.
Change subject: core: Initial support for alternative architectures
......................................................................
Patch Set 3:
(4 comments)
....................................................
File
backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd
Line 1178: <xs:element name="threads_as_cores" type="xs:boolean"
minOccurs="0" maxOccurs="1"/>
Line 1179: <xs:element name="tunnel_migration" type="xs:boolean"
minOccurs="0" maxOccurs="1"/>
Line 1180: <xs:element name="trusted_service" type="xs:boolean"
minOccurs="0" maxOccurs="1"/>
Line 1181: <xs:element name="ballooning_enabled" type="xs:boolean"
minOccurs="0" maxOccurs="1"/>
Line 1182: <xs:element name="architecture" type="xs:string"
minOccurs="0" maxOccurs="1"/>
having it r/o and fetching the arch from the cluster.cpu.id is better approach
indeed
Line 1183: <!-- Also a rel="networks" link -->
Line 1184: </xs:sequence>
Line 1185: </xs:extension>
Line 1186: </xs:complexContent>
....................................................
File
backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/util/ServerCpuParserTest.java
Line 52: }
Line 53:
Line 54: @Test
Line 55: public void testParseNoFlags() {
Line 56: List<ServerCpu> cpus = parseCpus("0:foo::blue:x86_64"); //
FIXME
where it is?
Line 57: assertNotNull(cpus);
Line 58: assertEquals(1, cpus.size());
Line 59: verifyCpu(cpus.get(0), 0, "foo", "blue", "x86_64");
Line 60: }
....................................................
File
backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/ClusterMapper.java
Line 52: if (model.isSetVersion() &&
model.getVersion().getMajor()!=null && model.getVersion().getMinor()!=null) {
Line 53: entity.setcompatibility_version(new
org.ovirt.engine.core.compat.Version(model.getVersion().getMajor(),
Line 54:
model.getVersion().getMinor()));
Line 55: }
Line 56: if (model.isSetArchitecture()) {
but impression i've got is it r/w? also you've documented it for write in the
rsdl_metadata.yaml (this meta is for client->server only)
Line 57: Architecture architecture =
Architecture.fromValue(model.getArchitecture());
Line 58: if (architecture != null) {
Line 59: entity.setArchitectureType(map(architecture, null));
Line 60: }
Line 53: entity.setcompatibility_version(new
org.ovirt.engine.core.compat.Version(model.getVersion().getMajor(),
Line 54:
model.getVersion().getMinor()));
Line 55: }
Line 56: if (model.isSetArchitecture()) {
Line 57: Architecture architecture =
Architecture.fromValue(model.getArchitecture());
where did you moved this line to?
Line 58: if (architecture != null) {
Line 59: entity.setArchitectureType(map(architecture, null));
Line 60: }
Line 61: }
--
To view, visit http://gerrit.ovirt.org/16700
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I33ed9231a6467aa59e8f3223ba9d61b6e68039fa
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vitor de Lima <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: Vitor de Lima <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
