Greg Sheremeta has uploaded a new change for review. Change subject: webadmin: fix duplicate events search results on Enter ......................................................................
webadmin: fix duplicate events search results on Enter This is a workaround for GWT bug 3533, "SuggestBox allows keyUp events to fire twice." The workaround is to attach the event handler to the SuggestBox's wrapped TextBox, not to the SuggestBox itself. Change-Id: I6fa8a023bdecf3d7a23eb10c940e069e2448d2fa Bug-Url: https://bugzilla.redhat.com/971695 Signed-off-by: Greg Sheremeta <[email protected]> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/SearchPanelPresenterWidget.java 1 file changed, 7 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/43/17943/1 diff --git a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/SearchPanelPresenterWidget.java b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/SearchPanelPresenterWidget.java index e2e0d5f..8e42bae 100644 --- a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/SearchPanelPresenterWidget.java +++ b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/SearchPanelPresenterWidget.java @@ -17,6 +17,7 @@ import com.google.gwt.event.dom.client.KeyDownEvent; import com.google.gwt.event.dom.client.KeyDownHandler; import com.google.gwt.event.shared.EventBus; +import com.google.gwt.user.client.ui.SuggestBox; import com.google.inject.Inject; import com.gwtplatform.mvp.client.PresenterWidget; import com.gwtplatform.mvp.client.View; @@ -126,7 +127,12 @@ } })); - registerHandler(getView().getSearchInputHandlers().addKeyDownHandler(new KeyDownHandler() { + + // Workaround GWT bug 3533. SuggestBox mistakenly fires key-downs twice. The workaround is + // to set the handler on the SuggestBox's internal TextBox. + SuggestBox searchSuggestBox = (SuggestBox) getView().getSearchInputHandlers(); + + registerHandler(searchSuggestBox.getValueBox().addKeyDownHandler(new KeyDownHandler() { @Override public void onKeyDown(KeyDownEvent event) { if (event.getNativeKeyCode() == KeyCodes.KEY_ENTER) { -- To view, visit http://gerrit.ovirt.org/17943 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I6fa8a023bdecf3d7a23eb10c940e069e2448d2fa Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
