Sandro Bonazzola has posted comments on this change. Change subject: packaging: disconnecting api instance at the end of all in one ......................................................................
Patch Set 1: I agree with Alon about the behavior that the SDK should have, however I think that this patch should be merged. The commit message may or may not saying that is needed as a workaround for SDK, but cleanly closing an opened connection when not used anymore is a good practice in any case. -- To view, visit http://gerrit.ovirt.org/17847 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8ece6bb8f825606442322a087fd52a647af64ffe Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ohad Basan <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Eyal Edri <[email protected]> Gerrit-Reviewer: Michael Pasternak <[email protected]> Gerrit-Reviewer: Moran Goldboim <[email protected]> Gerrit-Reviewer: Ofer Schreiber <[email protected]> Gerrit-Reviewer: Ohad Basan <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
