Juan Hernandez has posted comments on this change.
Change subject: Initial packaging
......................................................................
Patch Set 1:
(2 comments)
I detected a couple of minor errors, will submit a new patch set with them
corrected.
....................................................
File ovirt-scheduler-proxy.spec
Line 134: %systemd_post ovirt-scheduler-proxy.service
Line 135: %endif
Line 136:
Line 137: # Register the service:
Line 138: chkconfig --add ovirt-scheduler-proxy
This should be done conditionally if the install_systemv macro is defined.
Line 139:
Line 140:
Line 141: %postun
Line 142:
Line 171: %{_initddir}/ovirt-scheduler-proxy
Line 172: %endif
Line 173:
Line 174: # Data directory:
Line 175: %{_datadir}/ovirt-scheduler-proxy/plugins
This should be %{_datadir}/ovirt-scheduler-proxy.
Line 176:
Line 177: # Logs directory needs to be owned by the user that runs the service
because it
Line 178: # needs to create files inside:
Line 179: %attr(-, ovirt, ovirt) %{_localstatedir}/log/ovirt-scheduler-proxy
--
To view, visit http://gerrit.ovirt.org/17955
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8aa86f5ee80f40eb25a719fd72e75f7b275f38a0
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-scheduler-proxy
Gerrit-Branch: master
Gerrit-Owner: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
