Daniel Erez has posted comments on this change.
Change subject: core,restapi: attach detach storage connections
......................................................................
Patch Set 4:
(5 comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/StorageConnectionValidator.java
Line 26:
Line 27: return ValidationResult.VALID;
Line 28: }
Line 29:
Line 30: public ValidationResult isScsiConnectionAndDomain(StorageDomain
storageDomain) {
Done
Line 31: StorageType connectionStorageType =
connection.getstorage_type();
Line 32: StorageType storageDomainType = storageDomain.getStorageType();
Line 33:
Line 34: if (!connectionStorageType.equals(StorageType.ISCSI) ||
!storageDomainType.equals(StorageType.ISCSI)) {
Line 42: if (storageDomain == null) {
Line 43: return new
ValidationResult(VdcBllMessages.ACTION_TYPE_FAILED_STORAGE_DOMAIN_NOT_EXIST);
Line 44: }
Line 45: if (storageDomain.getStatus() !=
StorageDomainStatus.Maintenance
Line 46: && storageDomain.getStatus() !=
StorageDomainStatus.Unattached) {
Done
Line 47: return new
ValidationResult(VdcBllMessages.ACTION_TYPE_FAILED_STORAGE_CONNECTION_UNSUPPORTED_ACTION_FOR_DOMAINS_MAINTENANCE,
Line 48: String.format(STORAGE_DOMAIN_NAME_REPLACEMENT,
storageDomain.getStorageName()));
Line 49: }
Line 50:
Line 50:
Line 51: return ValidationResult.VALID;
Line 52: }
Line 53:
Line 54: public ValidationResult
isConnectionForDomainAlreadyExists(LUN_storage_server_connection_map
connectionMapRecord) {
Done
Line 55: if (connectionMapRecord != null) {
Line 56: return new
ValidationResult(VdcBllMessages.ACTION_TYPE_FAILED_STORAGE_CONNECTION_FOR_DOMAIN_ALREADY_EXISTS);
Line 57: }
Line 58:
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java
Line 227: MoveDisks(1012, false, QuotaDependency.NONE),
Line 228: ExtendImageSize(1013, false, QuotaDependency.STORAGE),
Line 229: ImportRepoImage(1014, ActionGroup.CREATE_DISK,
QuotaDependency.STORAGE),
Line 230: ExportRepoImage(1015, QuotaDependency.NONE),
Line 231: AttachStorageConnectionToStorageDomain(1016,
ActionGroup.MANIPULATE_STORAGE_DOMAIN, QuotaDependency.NONE),
Done
Line 232: DetachStorageConnectionFromStorageDomain(1017,
ActionGroup.MANIPULATE_STORAGE_DOMAIN, QuotaDependency.NONE),
Line 233:
Line 234: // Event Notification
Line 235: AddEventSubscription(1100, false, QuotaDependency.NONE),
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java
Line 455:
ACTION_TYPE_FAILED_STORAGE_DOMAIN_NOT_EXIST(ErrorType.BAD_PARAMETERS),
Line 456:
ACTION_TYPE_FAILED_STORAGE_CONNECTION_NOT_EXIST(ErrorType.BAD_PARAMETERS),
Line 457:
ACTION_TYPE_FAILED_STORAGE_CONNECTION_FOR_DOMAIN_NOT_EXIST(ErrorType.BAD_PARAMETERS),
Line 458:
ACTION_TYPE_FAILED_STORAGE_CONNECTION_ALREADY_EXISTS(ErrorType.BAD_PARAMETERS),
Line 459:
ACTION_TYPE_FAILED_STORAGE_CONNECTION_FOR_DOMAIN_ALREADY_EXISTS(ErrorType.BAD_PARAMETERS),
Done
Line 460:
ACTION_TYPE_FAILED_STORAGE_CONNECTION_UNSUPPORTED_ACTION_FOR_STORAGE_TYPE(ErrorType.NOT_SUPPORTED),
Line 461:
ACTION_TYPE_FAILED_STORAGE_CONNECTION_UNSUPPORTED_ACTION_FOR_DOMAINS_MAINTENANCE(ErrorType.NOT_SUPPORTED),
Line 462:
ACTION_TYPE_FAILED_STORAGE_CONNECTION_UNSUPPORTED_ACTION_FOR_RUNNING_VMS_AND_DOMAINS_MAINTENANCE(ErrorType.NOT_SUPPORTED),
Line 463:
ACTION_TYPE_FAILED_STORAGE_CONNECTION_UNSUPPORTED_ACTION_FOR_RUNNING_VMS(ErrorType.NOT_SUPPORTED),
--
To view, visit http://gerrit.ovirt.org/17864
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I319bc9f51c81e2df0c7ed3b3338fcd7b4783fe84
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
