Tomas Jelinek has posted comments on this change.
Change subject: Use FQDN from guest agent for RDP
......................................................................
Patch Set 8:
(3 comments)
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/form/AbstractFormPanel.java
Line 57: * Updates the value and visibility of the given item.
Line 58: */
Line 59: public void updateFormItem(FormItem item) {
Line 60: Widget valueWidget = item.resolveValueWidget();
Line 61: boolean visible = item.getIsAvailable();
forgotten space, please remove
Line 62:
Line 63: // Update item value
Line 64: valueWidget.setStyleName("formPanel_detailViewItemValue");
//$NON-NLS-1$
Line 65: Grid view = getDetailView(item.getColumn());
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmGeneralModelForm.java
Line 34: TextBoxLabel customProperties = new TextBoxLabel();
Line 35: TextBoxLabel domain = new TextBoxLabel();
Line 36: TextBoxLabel compatibilityVersion = new TextBoxLabel();
Line 37: TextBoxLabel vmId = new TextBoxLabel();
Line 38: TextBoxLabel fqdn = new TextBoxLabel();
please remove unneeded spaces
Line 39:
Line 40: BooleanLabel isHighlyAvailable;
Line 41:
Line 42: @Ignore
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/RdpConsoleModel.java
Line 74: if( getUseFqdnIfAvailable() ) {
Line 75: getLogger().debug("RDP connection is using FQDN if
available"); //$NON-NLS-1$
Line 76:
if(!StringHelper.isNullOrEmpty(getEntity().getVmFQDN())) {
Line 77: getLogger().debug("RDP connection is using FQDN
because it is available"); //$NON-NLS-1$
Line 78: getrdp().setAddress(getEntity().getVmFQDN());
I guess you have forgotten to "haveFqdn = true" ;)
Line 79: }
Line 80: }
Line 81:
Line 82: if( !haveFqdn ) {
--
To view, visit http://gerrit.ovirt.org/17709
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1e7f8e46c6a71ccbfe9af9bf85271d7294b03526
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Ori Liel <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: Vinzenz Feenstra <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
