Moti Asayag has posted comments on this change.
Change subject: core: Feature support version for Network QoS
......................................................................
Patch Set 11: Code-Review+2
(2 comments)
Please address minor comments
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
Line 1502: MaxSchedulerWeight(535),
Line 1503:
Line 1504: @TypeConverterAttribute(Boolean.class)
Line 1505: @DefaultValueAttribute("true")
Line 1506: NetworkQoSSupported(536),
s/NetworkQoSSupported/NetworkQosSupported
Line 1507:
Line 1508: Invalid(65535);
Line 1509:
Line 1510: private int intValue;
....................................................
File packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql
Line 203: select
fn_db_add_config_value('MomPoliciesOnHostSupported','true','3.3');
Line 204: select fn_db_add_config_value('NetworkQoSSupported','false','3.0');
Line 205: select fn_db_add_config_value('NetworkQoSSupported','false','3.1');
Line 206: select fn_db_add_config_value('NetworkQoSSupported','false','3.2');
Line 207: select fn_db_add_config_value('NetworkQoSSupported','true','3.3');
since the default is true, 3.3 isn't required.
Line 208:
Line 209: -- by default use no proxy
Line 210: select fn_db_add_config_value('SpiceProxyDefault','','general');
Line 211:
--
To view, visit http://gerrit.ovirt.org/17949
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0ad76a1d920c8b54e8d545212fa0ac8656292969
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: ofri masad <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-Reviewer: ofri masad <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
