Omer Frenkel has posted comments on this change. Change subject: core: importing external and hosted-engine VMs to the engine ......................................................................
Patch Set 7: Code-Review-1 since the canDoAction messages is the async part of the command i dont see a reason to add the vm name to the message, i think its obvious that if you start a vm, and get a message "Faild to run vm, vm is external" (or whatever) you know which vm, its the one you just clicked run on. we never add the object name to the canDoAction message, if we want to do something like this, its probably need to be everywhere and not just in this specific message. -- To view, visit http://gerrit.ovirt.org/17269 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6b933df39aaf6897a675aef0564d3fb4922f12e7 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Itamar Heim <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
