Alona Kaplan has posted comments on this change.
Change subject: webadmin: Add network QoS to Vnic Profile UI
......................................................................
Patch Set 14: Code-Review+2
(2 comments)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/profiles/NewVnicProfileModel.java
Line 12:
Line 13: private Guid dcId;
Line 14:
Line 15: public NewVnicProfileModel(EntityModel sourceModel, Version
dcCompatibilityVersion, boolean customPropertiesVisible,
Line 16: Guid dcId) {
Please move the dcId to the vnicProfleModel ctor.
Line 17: super(sourceModel, dcCompatibilityVersion,
customPropertiesVisible);
Line 18:
setTitle(ConstantsManager.getInstance().getConstants().vnicProfileTitle());
Line 19: setHashName("new_vnic_profile"); //$NON-NLS-1$
Line 20:
Line 20:
Line 21: this.dcId = dcId;
Line 22: if (dcId != null) {
Line 23: initNetworkQoSList(dcId, null);
Line 24: }
This code should reside in the VnicProfileModelC ctor.
Line 25:
Line 26: getPortMirroring().setEntity(false);
Line 27: }
Line 28:
--
To view, visit http://gerrit.ovirt.org/17923
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I94ac502681b23e6e2dd138cd5e4de7c6ec482daa
Gerrit-PatchSet: 14
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: ofri masad <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-Reviewer: ofri masad <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
