Arik Hadas has posted comments on this change.
Change subject: core: move network validations on run vm to RunVmValidator
......................................................................
Patch Set 1:
(1 comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/RunVmValidator.java
Line 392:
Line 393: /**
Line 394: * @return true if all VM network interfaces are valid
Line 395: */
Line 396: public ValidationResult validateNetworkInterfaces(VM vm) {
actually I wrong in the first bullet, we can still have the VM stored as class
member, and pass it in the constructor. I'll do it.
Line 397: Map<String, VmNetworkInterface> interfaceNetworkMap =
Entities.vmInterfacesByNetworkName(vm.getInterfaces());
Line 398: Set<String> interfaceNetworkNames =
interfaceNetworkMap.keySet();
Line 399: List<Network> clusterNetworks =
getNetworkDAO().getAllForCluster(vm.getVdsGroupId());
Line 400: Set<String> clusterNetworksNames =
Entities.objectNames(clusterNetworks);
--
To view, visit http://gerrit.ovirt.org/17971
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6aff70b45617e90deac826f2a873c1604c9a4241
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
