Maor Lipchuk has posted comments on this change.
Change subject: core: avoid disconnecting from used connections
......................................................................
Patch Set 4:
(2 comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ISCSIStorageHelper.java
Line 119: return (List<StorageServerConnections>)
CollectionUtils.subtract(connections, toRemove);
Line 120: }
Line 121:
Line 122: private void
fillConnectionDetailsIfNeeded(StorageServerConnections connection) {
Line 123: // in case that the connection id is null (when we received
it from vdsm for example) - we can attempt to load
don't you wanted to say that we recieve it from GUI instead of VDSM?
suggestion:
/s/we can attempt to load it from the DB by it's details/we load it from the DB
Line 124: // it from the db by it's details.
Line 125: if (connection.getid() == null) {
Line 126: List<StorageServerConnections> dbConnections =
DbFacade.getInstance().getStorageServerConnectionDao().getAllForConnection(connection);
Line 127: if (!dbConnections.isEmpty()) {
Line 120: }
Line 121:
Line 122: private void
fillConnectionDetailsIfNeeded(StorageServerConnections connection) {
Line 123: // in case that the connection id is null (when we received
it from vdsm for example) - we can attempt to load
Line 124: // it from the db by it's details.
/s/it's/its
Line 125: if (connection.getid() == null) {
Line 126: List<StorageServerConnections> dbConnections =
DbFacade.getInstance().getStorageServerConnectionDao().getAllForConnection(connection);
Line 127: if (!dbConnections.isEmpty()) {
Line 128: connection.setid(dbConnections.get(0).getid());
--
To view, visit http://gerrit.ovirt.org/17983
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7008e64ebce57fbbdb350810a5ffca6e0a7800cc
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
