Yaniv Bronhaim has posted comments on this change.
Change subject: API: Do not require root password for host add
......................................................................
Patch Set 1:
(1 comment)
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostsResource.java
Line 86:
Line 87: @Override
Line 88: public Response add(Host host) {
Line 89: validateEnums(Host.class, host);
Line 90: validateParameters(host, "name", "address");
I don't understand. I know that the engine verifies the authMethod and the
password fields, and that's enough. But also, we don't want to remove that
field as deprecated field for backward compatibility (check and review [1]
please). in the yaml we declare the root_password as optional field if ssh
object is not declared. what should be removed from there?
[1] http://gerrit.ovirt.org/#/c/17981
Line 91: VdsStatic staticHost = getMapper(Host.class,
VdsStatic.class).map(host, null);
Line 92: staticHost.setVdsGroupId(getClusterId(host));
Line 93: AddVdsActionParameters addParams = new
AddVdsActionParameters(staticHost, host.getRootPassword());
Line 94: if (host.isSetOverrideIptables()) {
--
To view, visit http://gerrit.ovirt.org/18002
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I506b844df10acfc17dcbce271755d37fdcdf0c7e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Yedidyah Bar David <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
