Vitor de Lima has posted comments on this change.
Change subject: engine: Vnic interface validation
......................................................................
Patch Set 1:
(1 comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/VmNicValidator.java
Line 61: /**
Line 62: * @return An error if the network interface type is not
compatible with the selected operating
Line 63: * system.
Line 64: */
Line 65: public ValidationResult isVersionCompatible() {
I think this method should have a better name, such as isCompatibleWithOs or
something like that.
Line 66:
Line 67: OsRepository osRepository =
SimpleDependecyInjector.getInstance().get(OsRepository.class);
Line 68:
Line 69: ArrayList<String> networkDevices =
osRepository.getNetworkDevices(osId, version);
--
To view, visit http://gerrit.ovirt.org/18042
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia1236826adbc021f4fa7f3816c6bd8a2f199de79
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gustavo Frederico Temple Pedrosa <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Leonardo Bianconi <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Vitor de Lima <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-Reviewer: ofri masad <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
