Allon Mureinik has posted comments on this change.
Change subject: core: change iso prefix command to be vds broker command
......................................................................
Patch Set 7: Code-Review+1
(1 comment)
Please add the final modifier there next time you rebase/touch this patch?
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IsoPrefixVDSCommand.java
Line 9: import
org.ovirt.engine.core.vdsbroker.irsbroker.StoragePoolInfoReturnForXmlRpc;
Line 10:
Line 11: public class IsoPrefixVDSCommand<T extends
VdsAndPoolIDVDSParametersBase> extends VdsBrokerCommand<T> {
Line 12:
Line 13: private static ConcurrentHashMap<Guid, String>
storagePoolIdToIsoPrefix = new ConcurrentHashMap<Guid, String>();
what about the "final" modifier you promised me in patchset 6? :-)
Line 14: private static ConcurrentHashMap<Guid, Object>
storagePoolIdToLockObj = new ConcurrentHashMap<Guid, Object>();
Line 15:
Line 16: public IsoPrefixVDSCommand(T parameters) {
Line 17: super(parameters);
--
To view, visit http://gerrit.ovirt.org/17815
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I272ce7b0407bf83bd47646941630362ecf0b18cc
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
