Allon Mureinik has uploaded a new change for review. Change subject: core: Remove DiskImage ctor only used in cloneOf ......................................................................
core: Remove DiskImage ctor only used in cloneOf Removed the ctor that isn't used anywhere except in the clopyOf(DiskImage) method. Removing this ctor makes the copyOf(DiskImage) method easier to understand, and the entire class easier to maintain. Change-Id: Ie0e37d1ef373bede0d0f7cd374a8126f338a2383 Signed-off-by: Allon Mureinik <[email protected]> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DiskImage.java 1 file changed, 9 insertions(+), 17 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/27/18127/1 diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DiskImage.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DiskImage.java index 7fd450c..2a2de88 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DiskImage.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DiskImage.java @@ -37,21 +37,6 @@ setLastModifiedDate(getCreationDate()); } - public DiskImage(DiskImageBase diskImageBase) { - setParentId(Guid.Empty); - setVolumeType(diskImageBase.getVolumeType()); - setvolumeFormat(diskImageBase.getVolumeFormat()); - setSize(diskImageBase.getSize()); - setDiskInterface(diskImageBase.getDiskInterface()); - setBoot(diskImageBase.isBoot()); - setWipeAfterDelete(diskImageBase.isWipeAfterDelete()); - setPropagateErrors(diskImageBase.getPropagateErrors()); - setQuotaId(diskImageBase.getQuotaId()); - setQuotaName(diskImageBase.getQuotaName()); - setQuotaEnforcementType(diskImageBase.getQuotaEnforcementType()); - setIsQuotaDefault(diskImageBase.isQuotaDefault()); - } - public Guid getImageId() { return getImage().getId(); } @@ -317,10 +302,17 @@ } public static DiskImage copyOf(DiskImage diskImage) { - // set DiskImageBase properties - DiskImage di = new DiskImage(diskImage); + DiskImage di = new DiskImage(); // set all private fields (imitate clone - deep copy) + di.setVolumeType(diskImage.getVolumeType()); + di.setvolumeFormat(diskImage.getVolumeFormat()); + di.setSize(diskImage.getSize()); + di.setBoot(diskImage.isBoot()); + di.setQuotaId(diskImage.getQuotaId()); + di.setQuotaName(diskImage.getQuotaName()); + di.setQuotaEnforcementType(diskImage.getQuotaEnforcementType()); + di.setIsQuotaDefault(diskImage.isQuotaDefault()); di.setActive(diskImage.getActive()); di.setCreationDate(new Date(diskImage.getCreationDate().getTime())); di.setLastModifiedDate(new Date(diskImage.getLastModifiedDate().getTime())); -- To view, visit http://gerrit.ovirt.org/18127 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ie0e37d1ef373bede0d0f7cd374a8126f338a2383 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
